jhaabhijeet864 commented on code in PR #4083:
URL:
https://github.com/apache/incubator-kie-tools/pull/4083#discussion_r4619029021
##########
packages/drools-lsp/drools-completion/src/main/java/org/drools/completion/DRLLintHelper.java:
##########
@@ -148,7 +156,7 @@ public static List<Diagnostic> lint(String text) {
if (mvelSeverity != null) {
out.addAll(lintMvelPropertyAccess(sanitized, mvelSeverity));
}
- return out;
+ return DRLLintSuppression.filter(out, text);
Review Comment:
Good catch. Filtering after collection means suppressed items exhaust the
20/50 diagnostic cap prematurely. I'll pass the suppression index directly into
the lint passes so the suppression check happens before incrementing the count
and hitting MAX_DIAGNOSTICS_PER_PASS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]