This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch branch-1.6
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/branch-1.6 by this push:
     new 8b6643934 [KYUUBI #3555] [FEATURE] Helm install help set kyuubi pod 
global env
8b6643934 is described below

commit 8b6643934262abaa5554de8dfb91a656b8960ae1
Author: zwangsheng <[email protected]>
AuthorDate: Sun Oct 9 22:19:05 2022 +0800

    [KYUUBI #3555] [FEATURE] Helm install help set kyuubi pod global env
    
    ### _Why are the changes needed?_
    
    On kubernetes case, we may need global env.
    We add examples in `docker/helm/values.yaml`
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including 
negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [x] [Run 
test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests)
 locally before make a pull request
    
    Closes #3555 from zwangsheng/feature/on_kubernetes_env.
    
    Closes #3555
    
    b3553dc3 [zwangsheng] add
    
    Authored-by: zwangsheng <[email protected]>
    Signed-off-by: Cheng Pan <[email protected]>
    (cherry picked from commit f3f51ebd066006e9a2d9ca76db4aa52387de5fa1)
    Signed-off-by: Cheng Pan <[email protected]>
---
 docker/helm/templates/kyuubi-deployment.yaml | 5 +++++
 docker/helm/values.yaml                      | 3 +++
 2 files changed, 8 insertions(+)

diff --git a/docker/helm/templates/kyuubi-deployment.yaml 
b/docker/helm/templates/kyuubi-deployment.yaml
index 89a32093e..a11ad51e9 100644
--- a/docker/helm/templates/kyuubi-deployment.yaml
+++ b/docker/helm/templates/kyuubi-deployment.yaml
@@ -64,6 +64,11 @@ spec:
           volumeMounts:
             - name: kyuubi-defaults
               mountPath: {{ .Values.server.conf.mountPath }}
+          env:
+            {{- range $key, $val := .Values.environments }}
+            - name: {{ $key }}
+              value: {{ $val | quote }}
+            {{- end }}
       volumes:
         - name: kyuubi-defaults
           configMap:
diff --git a/docker/helm/values.yaml b/docker/helm/values.yaml
index e7f570873..2477e0e01 100644
--- a/docker/helm/values.yaml
+++ b/docker/helm/values.yaml
@@ -47,6 +47,9 @@ server:
   conf:
     mountPath: /opt/kyuubi/conf
 
+environments:
+  KYUUBI_HOME: /opt/kyuubi
+
 service:
   type: NodePort
   # The default port limit of kubernetes is 30000-32767

Reply via email to