[
https://issues.apache.org/jira/browse/LIBCLOUD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747522#comment-13747522
]
Tomaz Muraus commented on LIBCLOUD-379:
---------------------------------------
Thanks.
I have a couple of questions and comments:
1. SECURITY_GROUP_NAMES = 'secgroup1, secgroup2' - is this line correct?
It looks weird, I don't see this kwarg being split anywhere. It's just passed
directly to the async_request method.
In any case, even if that is how it currently, works, we should move towards
improving it and unifying the extension argument handling, like we did in
LIBCLOUD-375.
I also haven't noticed any test cases for this functionality so it would be
good to add some.
Keep in mind that this it not blocker for merging this patch, just something we
should improve and fix in the short term.
2. For now we only have a single page for all the compute providers examples.
In the near future, we will have a documentation page / chapter for each
provider so you are welcome to add CloudStack specific documentation and
examples there when it becomes available.
> Adding CloudStack examples to docs
> ----------------------------------
>
> Key: LIBCLOUD-379
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-379
> Project: Libcloud
> Issue Type: Bug
> Reporter: sebastien goasguen
> Attachments: libcloud379.patch
>
>
> Found out about the new sphinx docs yesterday, this patch adds an example
> that matches the EC2_keypair_secgroup example. I actually copied it and
> modified what needed to be modified so it looks very similar.
> Tested with building docs with sphinx.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
