[
https://issues.apache.org/jira/browse/LIBCLOUD-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752692#comment-13752692
]
Tomaz Muraus commented on LIBCLOUD-388:
---------------------------------------
Thanks.
There are a couple of issues in this patch which need to be addressed before it
can be merged:
1. Missing "base64" and "b" import
2. pep8 / style issues
3. [ip for ip in private_ips if is_private_subnet(ip) == False] - should use
"if not is_private_subnet(..) here"
4. I assume "if keypair in vm.keys():" should be "if 'keypair' in vm.keys()",
because keypair is initialize to None. Same goes for the line bellow.
5. Need to add a note to documentation example which says that this
functionality is only available in trunk
6. Also need to add some test cases which exercises the new functionality and
catch the previously mentioned missing import issue.
> deploy_node not supported in cloudstack driver
> ----------------------------------------------
>
> Key: LIBCLOUD-388
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-388
> Project: Libcloud
> Issue Type: Bug
> Components: Compute
> Affects Versions: 0.12.3
> Reporter: sebastien goasguen
> Attachments: libcloud388.path
>
>
> deploy_node not available due to lack of auth
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
