[
https://issues.apache.org/jira/browse/LIBCLOUD-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753685#comment-13753685
]
John Carr commented on LIBCLOUD-388:
------------------------------------
Hello,
Sorry for not commenting on this sooner but i was only receiving notifications
about GitHub pull requests - that won't happen again!
The behaviour of create_node/deploy_node has changed in trunk and the "features
= {}" line is now used to indicate one of three things:
* If it contains "password", it should take a NodeAuthPassword via the "auth"
argument and pass that password to the Node that is created
* If it contains "ssh_key" it should take a NodeAuthSSHKey object via the
"auth" argument. That will contain a public key that should be used in teh
authorized_keys file in the created node
* If it contains "generates_password" then the VM creates a password and
returns it via an extra parameter.
I noticed your patch adds the "ssh_key" feature to CloudStack, but it does not
take a NodeAuthSSHKey parameter. That breaks the API and tools that rely on the
metadata will wrongly try and pass a NodeAuthSSHKey to your driver. So I am
going to revert that part of your patch.
deploy_node does not rely on the features metadata any more so this should not
impact your deploy_node fixes, but it would be good if you could do a follow up
pull request that properly supports NodeAuthSSHKey. It looks that CloudStack is
similar to EC2 here in that there is a keyring service of some kind. If you
look at the EC2 driver you will see it has a method called
ex_find_or_import_keypair_by_key_material which imports a key into the keyring
automatically if it doesnt exist already and gives you the key name.
> deploy_node not supported in cloudstack driver
> ----------------------------------------------
>
> Key: LIBCLOUD-388
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-388
> Project: Libcloud
> Issue Type: Bug
> Components: Compute
> Affects Versions: 0.12.3
> Reporter: sebastien goasguen
> Attachments: libcloud388.patch
>
>
> deploy_node not available due to lack of auth
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
