gyogal commented on code in PR #476:
URL: https://github.com/apache/incubator-livy/pull/476#discussion_r2124401002
##########
pom.xml:
##########
@@ -1189,11 +1198,18 @@
</properties>
</profile>
+<!--
+ <spark.scala-2.11.version>2.4.5</spark.scala-2.11.version>
+ <spark.scala-2.12.version>2.4.5</spark.scala-2.12.version>
+ <spark.version>${spark.scala-2.11.version}</spark.version>
+-->
Review Comment:
Why is this commented out? I think it may may break Spark 2 profiles. Spark
2 support should be removed at some point (possibly with the introduction of
Spark 4), but for now it would be good to retain compatibility.
##########
pom.xml:
##########
@@ -1189,11 +1198,18 @@
</properties>
</profile>
+<!--
+ <spark.scala-2.11.version>2.4.5</spark.scala-2.11.version>
+ <spark.scala-2.12.version>2.4.5</spark.scala-2.12.version>
+ <spark.version>${spark.scala-2.11.version}</spark.version>
+-->
<profile>
<id>spark3</id>
<properties>
- <spark.version>3.2.3</spark.version>
- <java.version>1.8</java.version>
+ <spark.scala-2.11.version>3.4.4</spark.scala-2.11.version>
+ <spark.scala-2.12.version>3.4.4</spark.scala-2.12.version>
+ <spark.version>3.4.4</spark.version>
+ <java.version>11</java.version>
Review Comment:
Could you please explain why this change is needed? Is it not enough to bump
"spark.version" and use "-Djava.version=11" if needed? Is there any reason why
Spark version 3.4.4 was picked and not 3.5.6 which is the latest version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
