Repository: logging-log4j2 Updated Branches: refs/heads/master d3c24001a -> de578598c
Add final modifier to method parameters. Add final modifier to local variables. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/de578598 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/de578598 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/de578598 Branch: refs/heads/master Commit: de578598c4dc3de7a0fee5a5c407d2af64449dff Parents: d3c2400 Author: Gary Gregory <[email protected]> Authored: Sat Sep 27 17:15:21 2014 -0400 Committer: Gary Gregory <[email protected]> Committed: Sat Sep 27 17:15:21 2014 -0400 ---------------------------------------------------------------------- .../apache/logging/log4j/core/config/AbstractConfiguration.java | 2 +- .../org/apache/logging/log4j/core/config/CustomLevelConfig.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/de578598/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java index fa5b4cb..5ca8112 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java @@ -375,7 +375,7 @@ public abstract class AbstractConfiguration extends AbstractFilterable implement } else if (child.getName().equalsIgnoreCase("CustomLevels")) { customLevels = ((CustomLevels) child.getObject()).getCustomLevels(); } else if (child.getObject() instanceof CustomLevelConfig) { - List<CustomLevelConfig> copy = new ArrayList<CustomLevelConfig>(customLevels); + final List<CustomLevelConfig> copy = new ArrayList<CustomLevelConfig>(customLevels); copy.add((CustomLevelConfig) child.getObject()); customLevels = copy; } else { http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/de578598/log4j-core/src/main/java/org/apache/logging/log4j/core/config/CustomLevelConfig.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/CustomLevelConfig.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/CustomLevelConfig.java index 24e772a..014a971 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/CustomLevelConfig.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/CustomLevelConfig.java @@ -81,14 +81,14 @@ public final class CustomLevelConfig { } @Override - public boolean equals(Object object) { + public boolean equals(final Object object) { if (this == object) { return true; } if (!(object instanceof CustomLevelConfig)) { return false; } - CustomLevelConfig other = (CustomLevelConfig) object; + final CustomLevelConfig other = (CustomLevelConfig) object; return this.intLevel == other.intLevel && this.levelName.equals(other.levelName); }
