Repository: logging-log4j2 Updated Branches: refs/heads/master b0216baca -> 3dc48528c
Add final modifier to method parameters. Add final modifier to local variables. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/3dc48528 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/3dc48528 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/3dc48528 Branch: refs/heads/master Commit: 3dc48528c01a956be47440b6f8b7fbda4ee2fe8e Parents: b0216ba Author: Gary Gregory <[email protected]> Authored: Wed Oct 22 01:57:21 2014 -0400 Committer: Gary Gregory <[email protected]> Committed: Wed Oct 22 01:57:21 2014 -0400 ---------------------------------------------------------------------- .../src/main/java/org/apache/logging/log4j/util/ProviderUtil.java | 2 +- .../src/main/java/org/apache/logging/log4j/core/LoggerContext.java | 2 +- .../org/apache/logging/log4j/core/config/ConfigurationFactory.java | 2 +- .../org/apache/logging/log4j/core/config/TestConfigurator.java | 2 +- .../org/apache/logging/log4j/core/selector/TestClassLoader.java | 2 +- .../src/test/java/org/apache/logging/log4j/jcl/LoggerTest.java | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/3dc48528/log4j-api/src/main/java/org/apache/logging/log4j/util/ProviderUtil.java ---------------------------------------------------------------------- diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/util/ProviderUtil.java b/log4j-api/src/main/java/org/apache/logging/log4j/util/ProviderUtil.java index 9fd7b35..f638d75 100644 --- a/log4j-api/src/main/java/org/apache/logging/log4j/util/ProviderUtil.java +++ b/log4j-api/src/main/java/org/apache/logging/log4j/util/ProviderUtil.java @@ -62,7 +62,7 @@ public final class ProviderUtil { private static volatile ProviderUtil INSTANCE; private ProviderUtil() { - for (LoaderUtil.UrlResource resource : LoaderUtil.findUrlResources(PROVIDER_RESOURCE)) { + for (final LoaderUtil.UrlResource resource : LoaderUtil.findUrlResources(PROVIDER_RESOURCE)) { loadProvider(resource.getUrl(), resource.getClassLoader()); } } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/3dc48528/log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java index 00a6042..4a642d6 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java @@ -211,7 +211,7 @@ public class LoggerContext extends AbstractLifeCycle implements org.apache.loggi this.setStopping(); try { Server.unregisterLoggerContext(getName()); // LOG4J2-406, LOG4J2-500 - } catch (Exception ex) { + } catch (final Exception ex) { LOGGER.error("Unable to unregister MBeans", ex); } if (shutdownCallback != null) { http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/3dc48528/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java index 1535152..29933d7 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java @@ -150,7 +150,7 @@ public abstract class ConfigurationFactory { } } Collections.sort(ordered, OrderComparator.getInstance()); - for (Class<? extends ConfigurationFactory> clazz : ordered) { + for (final Class<? extends ConfigurationFactory> clazz : ordered) { addFactory(list, clazz); } // see above comments about double-checked locking http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/3dc48528/log4j-core/src/test/java/org/apache/logging/log4j/core/config/TestConfigurator.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/config/TestConfigurator.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/config/TestConfigurator.java index 7b028e5..c54ef5c 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/config/TestConfigurator.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/config/TestConfigurator.java @@ -259,7 +259,7 @@ public class TestConfigurator { assertNotNull("Appenders map should not be null.", map); assertThat(map, hasSize(greaterThan(0))); assertThat("No ListAppender named List2", map, hasKey("List2")); - Appender app = map.get("List2"); + final Appender app = map.get("List2"); final Layout<? extends Serializable> layout = app.getLayout(); assertNotNull("Appender List2 does not have a Layout", layout); assertThat("Appender List2 is not configured with a PatternLayout", layout, instanceOf(PatternLayout.class)); http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/3dc48528/log4j-core/src/test/java/org/apache/logging/log4j/core/selector/TestClassLoader.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/selector/TestClassLoader.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/selector/TestClassLoader.java index 38f93b4..af4d422 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/selector/TestClassLoader.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/selector/TestClassLoader.java @@ -65,7 +65,7 @@ public class TestClassLoader extends ClassLoader { Closer.closeSilently(in); } return defineClass(name, bytecode, 0, bytecode.length); - } catch (IOException e) { + } catch (final IOException e) { Throwables.rethrow(e); return null; // unreachable } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/3dc48528/log4j-jcl/src/test/java/org/apache/logging/log4j/jcl/LoggerTest.java ---------------------------------------------------------------------- diff --git a/log4j-jcl/src/test/java/org/apache/logging/log4j/jcl/LoggerTest.java b/log4j-jcl/src/test/java/org/apache/logging/log4j/jcl/LoggerTest.java index de5b83f..6106b6f 100644 --- a/log4j-jcl/src/test/java/org/apache/logging/log4j/jcl/LoggerTest.java +++ b/log4j-jcl/src/test/java/org/apache/logging/log4j/jcl/LoggerTest.java @@ -42,7 +42,7 @@ public class LoggerTest { @Test public void testLog() { - Log logger = LogFactory.getLog("LoggerTest"); + final Log logger = LogFactory.getLog("LoggerTest"); logger.debug("Test message"); verify("List", "o.a.l.l.j.LoggerTest Test message MDC{}" + Constants.LINE_SEPARATOR); logger.debug("Exception: " , new NullPointerException("Test"));
