marcoabreu commented on a change in pull request #16335: [Numpy] Global numpy
shape flag
URL: https://github.com/apache/incubator-mxnet/pull/16335#discussion_r332626832
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -1524,12 +1524,15 @@ nightly_scala_demo_test_cpu() {
bash bin/run_im.sh
}
-nightly_estimator() {
+nightly_estimator_numpy_global_flag() {
Review comment:
Sorry I'm not following. Why is this even a nightly test?
Also, I don't think that this will work. When you change the name of the
function but not the point where it gets referenced (IF it gets referenced),
then it would break, right? But lets forget about that.
Why don't you make this a normal unit test? The test doesn't seem to fit
into a constraint that warrants nightly execution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
