marcoabreu commented on a change in pull request #16335: [Numpy] Global numpy 
shape flag
URL: https://github.com/apache/incubator-mxnet/pull/16335#discussion_r332649489
 
 

 ##########
 File path: ci/docker/runtime_functions.sh
 ##########
 @@ -1524,12 +1524,15 @@ nightly_scala_demo_test_cpu() {
     bash bin/run_im.sh
 }
 
-nightly_estimator() {
+nightly_estimator_numpy_global_flag() {
 
 Review comment:
   To me this seems like a normal feature - independent of where it's used, so 
I'd be in favour if we add a regular unit test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to