apeforest commented on a change in pull request #16898: Sparse int64 Large
tensor support
URL: https://github.com/apache/incubator-mxnet/pull/16898#discussion_r362114754
##########
File path: include/mxnet/c_api.h
##########
@@ -643,14 +643,14 @@ MXNET_DLL int MXNDArrayCreateSparseEx(int storage_type,
MXNET_DLL int MXNDArrayCreateSparseEx64(int storage_type,
const int64_t *shape,
- int ndim,
+ uint32_t ndim,
Review comment:
Why not make everything to int to be consistent? I think internally ndim is
always int.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
