apeforest commented on a change in pull request #16898: Sparse int64 Large tensor support URL: https://github.com/apache/incubator-mxnet/pull/16898#discussion_r362575884
########## File path: include/mxnet/c_api.h ########## @@ -643,14 +643,14 @@ MXNET_DLL int MXNDArrayCreateSparseEx(int storage_type, MXNET_DLL int MXNDArrayCreateSparseEx64(int storage_type, const int64_t *shape, - int ndim, + uint32_t ndim, Review comment: i c. In that case, I guess we can use uint32_t for both 32-bit and 64-bit API. But I would also check with Numpy project owner to see if -1 is not used for numpy operator. Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services