ChaiBapchya commented on a change in pull request #17456: Implement remaining nn_basic ops in opperf URL: https://github.com/apache/incubator-mxnet/pull/17456#discussion_r372721286
########## File path: benchmark/opperf/utils/benchmark_utils.py ########## @@ -148,6 +148,11 @@ def run_op_benchmarks(ops, dtype, ctx, profiler, warmup, runs): for op, op_params in ops.items(): # Prepare inputs for the operator inputs = prepare_op_inputs(op, op_params) + + # Testing Embedding op backwards is currently unsupported + if op == "Embedding": Review comment: Also just adding in `run_op_benchmarks` doesn't seal all ends There are couple of ways to run OpPerf For eg what happens when `run_performance_test` is used? Does he get an error? or will it seg_fault? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services