connorgoggins commented on a change in pull request #17456: Implement remaining 
nn_basic ops in opperf
URL: https://github.com/apache/incubator-mxnet/pull/17456#discussion_r372768206
 
 

 ##########
 File path: benchmark/opperf/utils/benchmark_utils.py
 ##########
 @@ -148,6 +148,11 @@ def run_op_benchmarks(ops, dtype, ctx, profiler, warmup, 
runs):
     for op, op_params in ops.items():
         # Prepare inputs for the operator
         inputs = prepare_op_inputs(op, op_params)
+
+        # Testing Embedding op backwards is currently unsupported
+        if op == "Embedding":
 
 Review comment:
   Done! :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to