sergeykolychev commented on a change in pull request #17610: MXNET-1447 [Perl]
Runtime features and large tensor support.
URL: https://github.com/apache/incubator-mxnet/pull/17610#discussion_r380326059
##########
File path: perl-package/AI-MXNet/lib/AI/MXNet/NDArray.pm
##########
@@ -384,8 +385,11 @@ method _slice (
)
{
confess("start $start > stop $stop") if $start > $stop;
+ my $sub = AI::MXNet::RunTime->Features()->is_enabled('INT64_TENSOR_SIZE')
+ ? \&AI::MXNetCAPI::NDArraySlice64
+ : \&AI::MXNetCAPI::NDArraySlice;
Review comment:
@tlby On python side the switch is made in the caller space. The c api has
two functions defined for each task, one with ```(u)?int32_t``` input/output
and another with `(u)?int64_t`
I don't know how to combine these two functions via the swig space.
Looks like a task for you to complete later the line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
