tlby commented on a change in pull request #17610: MXNET-1447 [Perl] Runtime
features and large tensor support.
URL: https://github.com/apache/incubator-mxnet/pull/17610#discussion_r380406036
##########
File path: perl-package/AI-MXNet/lib/AI/MXNet/NDArray.pm
##########
@@ -384,8 +385,11 @@ method _slice (
)
{
confess("start $start > stop $stop") if $start > $stop;
+ my $sub = AI::MXNet::RunTime->Features()->is_enabled('INT64_TENSOR_SIZE')
+ ? \&AI::MXNetCAPI::NDArraySlice64
+ : \&AI::MXNetCAPI::NDArraySlice;
Review comment:
If that's how things are done in Python, then no need to diverge from this
pattern. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
