samskalicky commented on a change in pull request #17569: [WIP] Adding sparse
support to MXTensor for custom operators
URL: https://github.com/apache/incubator-mxnet/pull/17569#discussion_r380404221
##########
File path: include/mxnet/lib_api.h
##########
@@ -229,20 +241,48 @@ enum MXReturnValue {
MX_SUCCESS = 1,
};
+struct MXSparse {
+ // Pointer to data.
+ void *data{nullptr};
+ // length of (non-zero) data.
+ int64_t data_len;
+
+ // To store aux data for sparse.
+ // For CSR, indices stores the col index of non-zero values.
+ // For row sparse, indices store row index of rows which have non-zero
values.
+ std::vector<int64_t> indices;
+
+ // For CSR, indptr gives the start and end index of data for each row.
+ // For row sparse, indptr is empty.
+ std::vector<int64_t> indptr;
+
+ void set(void *Data, const int64_t* Dims, int NDims, void *Indices,
+ int64_t IndicesLen, void *IndPtr = nullptr, int64_t IndPtrLen = 0) {
Review comment:
can we use lowercase here? like:
```
void *data_ptr
void *idx
int64_t num_idx
void* idx_ptr
int64_t num_idx_ptr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
