samskalicky commented on a change in pull request #17569: [WIP] Adding sparse
support to MXTensor for custom operators
URL: https://github.com/apache/incubator-mxnet/pull/17569#discussion_r380405556
##########
File path: src/c_api/c_api.cc
##########
@@ -114,13 +114,19 @@ void CustomFComputeDispatcher(const std::string op_name,
const std::vector<OpReqType>& req,
const std::vector<NDArray>& outputs) {
std::vector<void*> in_data, out_data;
- std::vector<const int64_t *> in_shapes, out_shapes;
+ std::vector<const int64_t*> in_shapes, out_shapes;
std::vector<int> in_dims, out_dims;
std::vector<int> in_types, out_types;
std::vector<size_t> in_verIDs, out_verIDs;
std::vector<const char*> in_dev_type, out_dev_type;
std::vector<int> in_dev_id, out_dev_id;
+ // Aux data for sparse representation.
Review comment:
lets not use the word "aux" here since we're not talking about auxiliary
params.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
