hzfan commented on a change in pull request #17510: MXNet FFI for Operator 
Imperative Invocation
URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r381179420
 
 

 ##########
 File path: ci/jenkins/Jenkins_steps.groovy
 ##########
 @@ -24,23 +24,23 @@ utils = load('ci/Jenkinsfile_utils.groovy')
 
 // mxnet libraries
 mx_lib = 'lib/libmxnet.so, lib/libmxnet.a, lib/libtvm_runtime.so, 
lib/libtvmop.so, lib/tvmop.conf, build/libcustomop_lib.so, 
build/libcustomop_gpu_lib.so, build/libsubgraph_lib.so, 
3rdparty/dmlc-core/libdmlc.a, 3rdparty/tvm/nnvm/lib/libnnvm.a'
-mx_lib_cython = 'lib/libmxnet.so, lib/libmxnet.a, lib/libtvm_runtime.so, 
lib/libtvmop.so, lib/tvmop.conf, build/libcustomop_lib.so, 
build/libcustomop_gpu_lib.so, build/libsubgraph_lib.so, 
3rdparty/dmlc-core/libdmlc.a, 3rdparty/tvm/nnvm/lib/libnnvm.a, 
python/mxnet/_cy3/*.so'
+mx_lib_cython = 'lib/libmxnet.so, lib/libmxnet.a, lib/libtvm_runtime.so, 
lib/libtvmop.so, lib/tvmop.conf, build/libcustomop_lib.so, 
build/libcustomop_gpu_lib.so, build/libsubgraph_lib.so, 
3rdparty/dmlc-core/libdmlc.a, 3rdparty/tvm/nnvm/lib/libnnvm.a, 
python/mxnet/_cy3/*.so, python/mxnet/_ffi/_cy3/*.so'
 
 Review comment:
   `_cython` contains files like `*.pxi` and `*.pyx`, which typically contain 
cython code, while `_cy3` stores the `*.so`. The relation between 
`python/mxnet/_ffi/_cy3` and `python/mxnet/_ffi/_cython` is analogous to that 
between `python/mxnet/_cy3` and `python/mxnet/cython`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to