reminisce commented on a change in pull request #17510: MXNet FFI for Operator
Imperative Invocation
URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r382280276
##########
File path: src/api/api_npi.cc
##########
@@ -0,0 +1,181 @@
+/*
Review comment:
Considering we are going to register all the operators, it's better to think
about the file hierarchy for operator registration and declare common util
functions, e.g. `SetInOut`, in a header. This does not have be implemented this
PR, but we need to plan this earlier than later. For example
```
src/
└── api
└── operator
├── nn
└── numpy
├── element_wise_binary.cc
├── element_wise_unary.cc
├── indexing.cc
├── linalg
├── random
└── reduction.cc
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
