leezu commented on a change in pull request #17639: Set Ninja build generator in config.cmake instead of commmand line URL: https://github.com/apache/incubator-mxnet/pull/17639#discussion_r382295339
########## File path: docs/static_site/src/pages/get_started/osx_setup.md ########## @@ -110,13 +110,10 @@ the guide in [Math Library Selection](build_from_source#math-library-selection). ```bash rm -rf build mkdir -p build && cd build -cmake -GNinja -C ../config.cmake .. -cmake --build . --parallel 8 +cmake -C ../config.cmake .. Review comment: I think it's reasonable to require specification of the config file. Otherwise users may not understand how to change the config. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
