leezu commented on a change in pull request #17639: Set Ninja build generator in config.cmake instead of commmand line URL: https://github.com/apache/incubator-mxnet/pull/17639#discussion_r382434226
########## File path: docs/static_site/src/pages/get_started/osx_setup.md ########## @@ -110,13 +110,10 @@ the guide in [Math Library Selection](build_from_source#math-library-selection). ```bash rm -rf build mkdir -p build && cd build -cmake -GNinja -C ../config.cmake .. -cmake --build . --parallel 8 +cmake -C ../config.cmake .. Review comment: > This option seems redundant and may cause confusion if users by chance specify a different file other than config.cmake. Maybe on the contrary, it can be useful to enable users to keep `config_1.cmake` and `config_2.cmake`, providing an easy way to switch between the two configs. Another reason for being explicit here is that our project's `CMakeLists.txt` may not only be used by MXNet "users", but also by third party projects adding MXNet as a dependency. But we can mitigate the second reason by only loading the config if mxnet is not included as a dependency of a third-party project. Thus please check the added commit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
