apeforest commented on a change in pull request #17645: [CI] Test CMake builds instead of Makefile builds URL: https://github.com/apache/incubator-mxnet/pull/17645#discussion_r382421089
########## File path: ci/docker/runtime_functions.sh ########## @@ -455,36 +437,40 @@ build_ubuntu_cpu() { build_ubuntu_cpu_openblas() { set -ex - export CC="gcc" - export CXX="g++" - build_ccache_wrappers - make \ - DEV=1 \ - USE_TVM_OP=1 \ - USE_CPP_PACKAGE=1 \ - USE_BLAS=openblas \ - USE_MKLDNN=0 \ - USE_DIST_KVSTORE=1 \ - USE_LIBJPEG_TURBO=1 \ - USE_SIGNAL_HANDLER=1 \ - -j$(nproc) - make cython PYTHON=python3 + pushd . + cmake \ + -DCMAKE_BUILD_TYPE="RelWithDebInfo" \ + -DUSE_TVM_OP=ON \ Review comment: I think we should turn off this by default and create a separate to test TVM_ON instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services