[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #17645: [CI] Test CMake builds instead of Makefile builds

[GitBox]

apeforest commented on a change in pull request #17645: [CI] Test CMake builds 
instead of Makefile builds
URL: https://github.com/apache/incubator-mxnet/pull/17645#discussion_r382421639
 
 

 ##########
 File path: ci/docker/runtime_functions.sh
 ##########
 @@ -855,7 +830,6 @@ build_ubuntu_gpu_cmake_mkldnn() {
         -DUSE_CUDA=1                            \
         -DUSE_CUDNN=1                           \
         -DUSE_TVM_OP=1                          \
 
 Review comment:
   I think we should turn off this by default and create a separate to test 
TVM_ON instead.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services