apeforest commented on a change in pull request #17639: Set Ninja build 
generator in config.cmake instead of commmand line
URL: https://github.com/apache/incubator-mxnet/pull/17639#discussion_r382740830
 
 

 ##########
 File path: config/darwin.cmake
 ##########
 @@ -27,11 +27,8 @@
 #  Next modify the according entries, and then compile by
 #
 #  $ mkdir build; cd build
-#  $ cmake -C ../config.cmake ..
-#  $ cmake --build . --parallel 8
-#
-# You can increase the --parallel 8 argument to match the number of processor
 
 Review comment:
   I can we can leave this sentence here but remove --parallel 8 from the 
command line.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to