leezu commented on a change in pull request #17645: [CI] Test CMake builds
instead of Makefile builds
URL: https://github.com/apache/incubator-mxnet/pull/17645#discussion_r384655883
##########
File path: cmake/Modules/FindMKL.cmake
##########
@@ -122,10 +126,9 @@ set(INTEL_ROOT "/opt/intel" CACHE PATH "Folder contains
intel libs")
list(APPEND MKL_LIBRARIES ${${__mkl_lib_upper}_LIBRARY})
endforeach()
-
if(NOT MKL_USE_SINGLE_DYNAMIC_LIBRARY)
- if (MKL_USE_STATIC_LIBS)
- set(__iomp5_libs iomp5 libiomp5mt.lib)
+ if (MKL_USE_STATIC_LIBS AND UNIX)
+ set(__iomp5_libs libiomp5.a libiomp5mt.lib)
Review comment:
@cjolivier01 I'll remove testing MKL builds from this PR and you can
contribute a separate PR that fixes MKL build and enables tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
