apeforest commented on a change in pull request #17645: [CI] Test CMake builds
instead of Makefile builds
URL: https://github.com/apache/incubator-mxnet/pull/17645#discussion_r384734352
##########
File path: 3rdparty/mshadow/mshadow/base.h
##########
@@ -839,7 +840,7 @@ MSHADOW_XINLINE bool MaxValue<bool>(void) {
/*! \brief maximum value of uint32_t */
template<>
MSHADOW_XINLINE uint32_t MaxValue<uint32_t>(void) {
- return -1;
+ return std::numeric_limits<uint32_t>::max();
Review comment:
What's the indication of this change? Would it break some existing logic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
