larroy commented on a change in pull request #8915: NVLink communication
pattern updated
URL: https://github.com/apache/incubator-mxnet/pull/8915#discussion_r160935226
##########
File path: src/kvstore/comm.h
##########
@@ -53,33 +52,32 @@ class Comm {
/**
* \brief returns src[0] + .. + src[src.size()-1]
*/
- virtual const NDArray& Reduce(
- int key, const std::vector<NDArray>& src, int priority) = 0;
+ virtual const NDArray& Reduce(int key, const std::vector<NDArray>& src,
+ int priority) = 0;
/**
* \brief copy from src to dst[i] for every i
*/
- virtual void Broadcast(
- int key, const NDArray& src,
- const std::vector<NDArray*> dst, int priority) = 0;
+ virtual void Broadcast(int key, const NDArray& src,
+ const std::vector<NDArray*> dst, int priority) = 0;
Review comment:
vector is passed by value, shouldn't it be passed by ref?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
