larroy commented on a change in pull request #8915: NVLink communication
pattern updated
URL: https://github.com/apache/incubator-mxnet/pull/8915#discussion_r160935045
##########
File path: src/kvstore/comm.h
##########
@@ -22,29 +22,28 @@
*/
#ifndef MXNET_KVSTORE_COMM_H_
#define MXNET_KVSTORE_COMM_H_
+#define NVLINK_SUPPORT 4
#include <dmlc/omp.h>
-#include <string>
#include <algorithm>
-#include <utility>
#include <limits>
-#include <vector>
-#include <tuple>
+#include <string>
#include <thread>
-#include "mxnet/ndarray.h"
-#include "gradient_compression.h"
+#include <tuple>
+#include <utility>
+#include <vector>
#include "../ndarray/ndarray_function.h"
#include "../operator/tensor/sparse_retain-inl.h"
+#include "gradient_compression.h"
+#include "mxnet/ndarray.h"
namespace mxnet {
namespace kvstore {
/**
* \brief multiple device commmunication
*/
class Comm {
public:
- Comm() {
- pinned_ctx_ = Context::CPUPinned(0);
- }
- virtual ~Comm() { }
+ Comm() { pinned_ctx_ = Context::CPUPinned(0); }
Review comment:
Why don't we initialize on the constructor initialization list? It's more
efficient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
