yzhliu commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs URL: https://github.com/apache/incubator-mxnet/pull/9678#discussion_r174996407
########## File path: scala-package/infer/src/main/scala/ml/dmlc/mxnet/infer/MXNetHandler.scala ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package ml.dmlc.mxnet.infer + +import java.util.concurrent._ + +import org.slf4j.LoggerFactory + +private[infer] trait MXNetHandler { + + def execute[T](f: => T): T + + val executor: ExecutorService + +} + +private[infer] object MXNetHandlerType extends Enumeration { + + type MXNetHandlerType = Value + val SingleThreadHandler = Value("MXNetSingleThreadHandler") + val OneThreadPerModelHandler = Value("MXNetOneThreadPerModelHandler") +} + +private[infer] class MXNetThreadPoolHandler(numThreads: Option[Int] = Some(1)) + extends MXNetHandler { + private val logger = LoggerFactory.getLogger(classOf[MXNetThreadPoolHandler]) + + private val threadFactory = new ThreadFactory { + + override def newThread(r: Runnable): Thread = new Thread(r) { + setName(classOf[MXNetThreadPoolHandler].getCanonicalName + + "-numThreads: %d".format(numThreads.get)) + } + } + + override val executor: ExecutorService = + Executors.newFixedThreadPool(numThreads.get, threadFactory) + + private val creatorThread = executor.submit(new Callable[Thread] { + override def call(): Thread = Thread.currentThread() + }).get() + + override def execute[T](f: => T): T = { + + if (Thread.currentThread() eq creatorThread) { + f + } + + val task = new Callable[T] { + override def call(): T = { + logger.debug("threadId: %s".format(Thread.currentThread().getId())) + f Review comment: better to write f() to distinct from a return of a function variable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
