yzhliu commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs URL: https://github.com/apache/incubator-mxnet/pull/9678#discussion_r174996978
########## File path: scala-package/infer/src/main/scala/ml/dmlc/mxnet/infer/Predictor.scala ########## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package ml.dmlc.mxnet.infer + +import ml.dmlc.mxnet.io.NDArrayIter +import ml.dmlc.mxnet.{Context, DataDesc, NDArray, Shape} +import ml.dmlc.mxnet.module.Module + +import scala.collection.mutable.ListBuffer +import org.slf4j.LoggerFactory + +/** + * Base Trait for MXNet Predictor classes. + */ +private[mxnet] trait PredictBase { + + /** + * This method will take input as IndexedSeq one dimensional arrays and creates + * NDArray needed for inference. The array will be reshaped based on the input descriptors. + * @param input: A IndexedSequence of Scala one-dimensional array, An IndexedSequence is + * is needed when the model has more than one input/output Review comment: Feel confused with 'An IndexedSequence is is needed when the model has more than one input/output'. The `IndexedSeq` is not about model, it's just an array of input data, one entry for one input sample, right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
