eric-haibin-lin commented on a change in pull request #10371: [MXNET-263]
Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU
URL: https://github.com/apache/incubator-mxnet/pull/10371#discussion_r180294853
##########
File path: src/operator/tensor/dot-inl.h
##########
@@ -45,13 +45,20 @@ namespace op {
struct DotParam : public dmlc::Parameter<DotParam> {
bool transpose_a;
bool transpose_b;
+ dmlc::optional<int> forward_stype_hint;
DMLC_DECLARE_PARAMETER(DotParam) {
DMLC_DECLARE_FIELD(transpose_a)
.describe("If true then transpose the first input before dot.")
.set_default(false);
DMLC_DECLARE_FIELD(transpose_b)
.describe("If true then transpose the second input before dot.")
.set_default(false);
+ DMLC_DECLARE_FIELD(forward_stype_hint)
+ .describe("Desired storage type of the forward output.")
Review comment:
Need to be more detailed than this. Explicitly state that if no such
combination is implemented, dense op is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
