eric-haibin-lin commented on a change in pull request #10371: [MXNET-263]
Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU
URL: https://github.com/apache/incubator-mxnet/pull/10371#discussion_r180295176
##########
File path: src/operator/tensor/dot-inl.h
##########
@@ -216,32 +223,60 @@ inline bool DotForwardInferStorageType(const
nnvm::NodeAttrs& attrs,
bool only_lhs_transpose = param.transpose_a && !param.transpose_b;
bool rhs_rsp_or_dns =
rhs_stype == kRowSparseStorage || rhs_stype == kDefaultStorage;
+ NDArrayStorageType target_stype;
if (!dispatched && lhs_stype == kDefaultStorage &&
rhs_stype == kDefaultStorage) {
// dns, dns -> dns
- dispatched = storage_type_assign(&out_stype, kDefaultStorage,
dispatch_mode,
- DispatchMode::kFCompute);
+ target_stype = (param.forward_stype_hint.has_value())?
Review comment:
nit: This line is quite long. Maybe cache the value of
`param.forward_stype_hint.has_value()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
