spidyDev commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix URL: https://github.com/apache/incubator-mxnet/pull/10425#discussion_r180909444
########## File path: python/mxnet/io.py ########## @@ -645,8 +647,8 @@ def __init__(self, data, label=None, batch_size=1, shuffle=False, label_name='softmax_label'): super(NDArrayIter, self).__init__(batch_size) - self.data = _init_data(data, allow_empty=False, default_name=data_name) - self.label = _init_data(label, allow_empty=True, default_name=label_name) + self.data, self.renamed_data = _init_data(data, allow_empty=False, default_name=data_name) + self.label, _ = _init_data(label, allow_empty=True, default_name=label_name) Review comment: Looking in to this, i do not see a scenario in which we will have issues with the label. User can create NDIterator for labels and can bind only few of them . It should not affect the forward pass . Correct me if I am missing something here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services