reminisce commented on a change in pull request #10482: [MXNET-303] Update Jetpack to version 3.2 URL: https://github.com/apache/incubator-mxnet/pull/10482#discussion_r183176339
########## File path: Makefile ########## @@ -254,8 +254,10 @@ ifneq ($(ADD_LDFLAGS), NONE) LDFLAGS += $(ADD_LDFLAGS) endif -ifneq ($(USE_CUDA_PATH), NONE) - NVCC=$(USE_CUDA_PATH)/bin/nvcc +ifeq ($(NVCC), NONE) Review comment: This change introduces the compile error when `nvcc` command is not defined in global scope. In that case, `$(NVCC)` is not `NONE`, but since `nvcc` is not defined in global scope, the compile would fail. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services