KellenSunderland commented on a change in pull request #10482: [MXNET-303]
Update Jetpack to version 3.2
URL: https://github.com/apache/incubator-mxnet/pull/10482#discussion_r183178442
##########
File path: Makefile
##########
@@ -254,8 +254,10 @@ ifneq ($(ADD_LDFLAGS), NONE)
LDFLAGS += $(ADD_LDFLAGS)
endif
-ifneq ($(USE_CUDA_PATH), NONE)
- NVCC=$(USE_CUDA_PATH)/bin/nvcc
+ifeq ($(NVCC), NONE)
Review comment:
A follow up PR logs more verbose warnings when this happens, and does select
/usr/local/cuda/bin/nvcc as a fall back when nvcc isn't on the path. The
original implementation overwrote any value put into nvcc which would break
compilation in many use cases when trying to cross compile. The nvcc option
was ignored in these cases and it still would just use whichever nvcc was your
system default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
