anirudh2290 commented on a change in pull request #10666: [MXNET-359] fix
checks on convolution parameters in MKLDNN.
URL: https://github.com/apache/incubator-mxnet/pull/10666#discussion_r183628689
##########
File path: src/operator/nn/mkldnn/mkldnn_deconvolution.cc
##########
@@ -32,6 +32,12 @@
namespace mxnet {
namespace op {
+bool SupportMKLDNNConv(const DeconvolutionParam& params, const NDArray &input)
{
+ if (params.kernel.ndim() != 2)
Review comment:
do we need to add check for strides and dilate too ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
