[GitHub] anirudh2290 commented on a change in pull request #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN.

[GitBox]

anirudh2290 commented on a change in pull request #10666: [MXNET-359] fix 
checks on convolution parameters in MKLDNN.
URL: https://github.com/apache/incubator-mxnet/pull/10666#discussion_r183628039
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_convolution.cc
 ##########
 @@ -123,16 +123,15 @@ static 
mkldnn::convolution_backward_weights::primitive_desc GetConvBwdWeights(
   auto weight_md = GetWeightDesc(weights, param.num_group);
   auto out_md = GetMemDesc(output);
   auto engine = CpuEngine::Get()->get_engine();
+  CHECK_GE(param.stride.ndim(), 2U);
 
 Review comment:
   should this be CHECK_EQ ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services