ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220034121
########## File path: src/operator/subgraph/mkldnn/mkldnn_conv-inl.h ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#ifndef MXNET_OPERATOR_SUBGRAPH_MKLDNN_MKLDNN_CONV_INL_H_ +#define MXNET_OPERATOR_SUBGRAPH_MKLDNN_MKLDNN_CONV_INL_H_ +#if MXNET_USE_MKLDNN == 1 + +#include <utility> +#include <vector> +#include <string> +#include "../../nn/convolution-inl.h" +#include "../../nn/batch_norm-inl.h" +#include "../../nn/mkldnn/mkldnn_convolution-inl.h" + +namespace mxnet { +namespace op { + +struct MKLDNNConvFusionParam { + MKLDNNConvFullParam full_conv_param; + std::shared_ptr<BatchNormParam> bn_param; +}; Review comment: It's an abstraction to isolate mkldnn convolution params with fusion params: MKLDNNConvFullParam defines in mkldnn_convolution-inl.h, which only contains the options convolution needed, and will pass to MKLDNNConvolutionForwardFullFeature. MKLDNNConvFusionParam defines in mkldnn_conv-inl.h, which is used for SgMKLDNNConvParamParser, and to support fusion related function in SgMKLDNNConvOperator::Forward. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
