ZhennanQin commented on a change in pull request #12530: Implement mkldnn 
convolution fusion and quantization.
URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222594664
 
 

 ##########
 File path: src/c_api/c_api_symbolic.cc
 ##########
 @@ -696,3 +696,21 @@ int MXSetCalibTableToQuantizedSymbol(SymbolHandle 
qsym_handle,
   *ret_qsym_handle = s;
   API_END_HANDLE_ERROR(delete s);
 }
+
+int MXGenBackendSubgraph(SymbolHandle sym_handle, const char *backend,
 
 Review comment:
   What do you mean by a placeholder for the fused mkldnn call?
   This API is intend for converting a symbol into a backend specific symbol. 
On quantization flow, we need do fusion at first, and then do quantization. So 
on python level, we need to get the backend specific symbol that all backend 
specific fusion applied, and pass it to quantization pass. That's why we need 
this API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to