ZhennanQin commented on a change in pull request #12530: Implement mkldnn
convolution fusion and quantization.
URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222603978
##########
File path: src/ndarray/ndarray.cc
##########
@@ -1592,8 +1601,12 @@ void NDArray::Save(dmlc::Stream *strm) const {
save_data = nd_cpu.data();
} else {
this->WaitToRead();
- save_data = this->data();
nd_cpu = *this;
+#if MXNET_USE_MKLDNN == 1
+ if (nd_cpu.IsMKLDNNData())
Review comment:
I don't see such rule from the code itself. Single line conditionals without
braces can be found everywhere, even in this file. See line 1591, 1654, 1669 ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
