KellenSunderland commented on a change in pull request #13310: [MXNET-703] Update to TensorRT 5, ONNX IR 3. Fix inference bugs. URL: https://github.com/apache/incubator-mxnet/pull/13310#discussion_r236058587
########## File path: src/operator/contrib/nnvm_to_onnx.cc ########## @@ -78,8 +84,13 @@ op::TRTParam ConvertNnvmGraphToOnnx( ModelProto model_proto; // Need to determine IR versions and features to support - model_proto.set_ir_version(static_cast<int64>(2)); + auto opset_proto = model_proto.add_opset_import(); + opset_proto->set_version(static_cast<int64>(8)); Review comment: Yeah I could refactor these to give stronger names. It's basically just declaring the IR version of ONNX protos we're using. This wouldn't be dynamic, it's a static declaration of what ONNX version we're serializing to (ONNX 3). Opset is similar, it's a slightly differently semantically versioned subset of operators within ONNX 3 that we're using. So basically together we declare here that we're support ONNX 3, opset 8. I'll update this to add some clarity tomorrow. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
