KellenSunderland commented on a change in pull request #13310: [MXNET-703]
Update to TensorRT 5, ONNX IR 3. Fix inference bugs.
URL: https://github.com/apache/incubator-mxnet/pull/13310#discussion_r236131269
##########
File path: src/operator/contrib/nnvm_to_onnx.cc
##########
@@ -248,8 +259,12 @@ void ConvertPooling(NodeProto* node_proto, const
NodeAttrs& attrs,
AttributeProto* const pads = node_proto->add_attribute();
pads->set_name("pads");
pads->set_type(AttributeProto::INTS);
- for (int kval : pad) {
- pads->add_ints(static_cast<int64>(kval));
+
+ // Convert from MXNet symetric pads to ONNX non-symetric by running through
padding twice.
+ for (int i =0; i < 2; i++) {
Review comment:
Wait until after 1.4 for sure, it's a big change that will require a lot of
discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
