abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit
API]Add validation support and unit tests for fit() API
URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r267094300
##########
File path: python/mxnet/gluon/estimator/estimator.py
##########
@@ -192,6 +230,9 @@ def fit(self, train_data,
not any(isinstance(handler, LoggingHandler) for handler in
event_handlers):
event_handlers.append(LoggingHandler(self))
+ # Check for validation data
+ do_validation = True if val_data else False
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
