abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit 
API]Add validation support and unit tests for fit() API
URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r269256381
 
 

 ##########
 File path: python/mxnet/gluon/estimator/estimator.py
 ##########
 @@ -77,6 +77,10 @@ def __init__(self, net,
                 raise ValueError("metrics must be a Metric or a list of 
Metric, "
                                  "refer to 
mxnet.metric.EvalMetric:{}".format(metrics))
 
+        # Use default mx.metric.Accuracy() for 
gluon.loss.SoftmaxCrossEntropyLoss()
+        if not self.train_metrics and any([isinstance(l, 
gluon.loss.SoftmaxCrossEntropyLoss) for l in self.loss]):
 
 Review comment:
   Yes, tracking it using JIRA issue: 
https://issues.apache.org/jira/browse/MXNET-1364

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to