anirudh2290 commented on a change in pull request #14397: Add exception
handling support for waitall
URL: https://github.com/apache/incubator-mxnet/pull/14397#discussion_r267953823
##########
File path: tests/python/unittest/test_exc_handling.py
##########
@@ -77,46 +86,83 @@ def gluon(exec_wait=True):
y = model(x)
model.collect_params().initialize(ctx=[default_context()])
z = model(mx.nd.random.normal(10, -10, (32, 2, 10),
ctx=default_context()))
- if exec_wait:
+ if waitall:
+ mx.nd.waitall()
+ elif exec_wait:
z.wait_to_read()
gluon(exec_wait=False)
- assert_raises(MXNetError, gluon, True)
+ assert_raises(MXNetError, gluon, exec_wait=True)
+
+ assert_raises(MXNetError, gluon, waitall=True)
@with_seed()
def test_exc_multiple_waits():
- caught = False
- try:
- a = mx.nd.random.normal(0, -1, (2, 2)).copyto(default_context())
- a.wait_to_read()
- except MXNetError:
- caught = True
- assert caught, "No exception thrown"
- try:
- b = mx.nd.random.normal(0, -1, (2, 2)).copyto(default_context())
- b.wait_to_read()
- except MXNetError:
- caught = True
- assert caught, "No exception thrown"
+ def multiple_waits(waitall=False):
Review comment:
I have added comments. Intention is to test multiple wait_to_reads and
waitalls for vars in same scope.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
