anirudh2290 commented on a change in pull request #14397: Add exception
handling support for waitall
URL: https://github.com/apache/incubator-mxnet/pull/14397#discussion_r267954717
##########
File path: src/engine/threaded_engine.cc
##########
@@ -415,6 +415,25 @@ void ThreadedEngine::WaitForAll() {
finished_cv_.wait(lock, [this]() {
return pending_.load() == 0 || kill_.load();
});
+ std::exception_ptr tmp;
Review comment:
Currently it is used only once so it is fine to not use a function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
