KellenSunderland commented on a change in pull request #15399: Add unit tests 
for TensorRT integration and fix some bugs
URL: https://github.com/apache/incubator-mxnet/pull/15399#discussion_r302336971
 
 

 ##########
 File path: src/operator/subgraph/tensorrt/nnvm_to_onnx.cc
 ##########
 @@ -157,6 +157,12 @@ std::string ConvertNnvmGraphToOnnx(
   return serialized_onnx_graph;
 }
 
+void ConvertIdentity(NodeProto* node_proto, const NodeAttrs& attrs,
 
 Review comment:
   Any idea if TRT actually optimizes this out?  I've seen this in a few prod 
services :-/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to