KellenSunderland commented on a change in pull request #15399: Add unit tests
for TensorRT integration and fix some bugs
URL: https://github.com/apache/incubator-mxnet/pull/15399#discussion_r302338157
##########
File path: src/operator/subgraph/tensorrt/tensorrt-inl.h
##########
@@ -180,6 +253,17 @@ class TensorrtProperty : public SubgraphProperty {
n->attrs.name = "TensorRT" + std::to_string(subgraph_id);
n->attrs.op = Op::Get("_TensorRT");
CHECK(n->attrs.op);
+ // prevent using Gamma value if using fix_gamma on BatchNorm
+ DFSVisit(new_sym.outputs, [&n](const nnvm::NodePtr& node) {
+ if (node->op() == Op::Get("BatchNorm")) {
Review comment:
Why not just check for FixGamma = true during nnvm -> Onnx conversion and
set gamma to 1 if it's true?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
