Zha0q1 commented on a change in pull request #15580: update profiler tutorial URL: https://github.com/apache/incubator-mxnet/pull/15580#discussion_r305599927
########## File path: docs/tutorials/python/profiler.md ########## @@ -193,10 +193,10 @@ print(profiler.dumps()) You can also dump the information collected by the profiler into a `json` file using the `profiler.dump()` function and view it in a browser. ```python -profiler.dump() +profiler.dump(finished=False) Review comment: I think a Jupyter Notebook file will be auto-generated based on this tutorial which use can download and run. Anirudh said this tutorial was failing the nightly test so I came up with this fix. If we do not use `finished = False` here, the code in the next section will error out in the tutorial nightly test (because the profiler has finished). Because you can only have one profiler per script, I think there might not be any workaround except for setting finished to False here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
